Pull various ReadableStream fixes from WebKit #13840

refi64 · 2024-09-10T00:44:56Z

This pulls the following fixes from WebKit:

Error on piped ReadableStream leads to Unhandled Promise Rejection WebKit/WebKit@3a75b5d
Mark pipeThrough pipeTo promise as handled as per streams spec WebKit/WebKit@07e4b92
ReadableStreamError should reject closed promise before erroring read promises WebKit/WebKit@1f74c15
ReadableStreamDefaultReader.releaseLock is now rejecting pending read promises WebKit/WebKit@f8ae40c

The first of these fixes #13816.

New automated tests for each case.

Jarred-Sumner · 2024-09-10T03:09:34Z

There are some test failures. We were probably unintentionally relying on this behavior

ctjlewis · 2024-09-10T03:26:50Z

Thank you @refi64. I'm back on 1.1.26 for now.

refi64 · 2024-09-10T04:05:06Z

Oh oof, I had thought CI ran the full test suite 😅

refi64 and others added 5 commits September 11, 2024 21:03

Fix pipeTo unhandled rejections on readable errors

1452755

WebKit/WebKit@3a75b5d Fixes oven-sh#13816.

Fix pipeThrough unhandled rejections on readable errors

d6e85af

WebKit/WebKit@07e4b92

Update the ReadableStream promise resolution ordering on pull rejection

06ba0dc

WebKit/WebKit@1f74c15

Reject pending reads when a ReadableStream's lock is released

605f0db

WebKit/WebKit@f8ae40c

Add $ERR_STREAM_RELEASE_LOCK

5a1c29f

Jarred-Sumner force-pushed the webkit-streams-fixes branch from 402a6cc to 5a1c29f Compare September 12, 2024 04:07

Jarred-Sumner mentioned this pull request Sep 12, 2024

Fixes #13816 #13906

Open

Provide feedback